[vlc-devel] OSD sliders on OSX.
fenrir at via.ecp.fr
Tue Jun 2 13:04:37 CEST 2009
On Tue, Jun 02, 2009, Derk-Jan Hartman wrote:
> It seems that in hotkeys.c the presentation of these elements is wrapped
> in if( p_vout->b_fullscreen ).
> In the 0.9 tree it was if( !p_vout->p_window || p_vout->b_fullscreen )
> Since p_window was NULL on OSX, this condition was always true. However
> the p_window has been removed, and now p_vout->b_fullscreen has become
> important. It seems however that on OSX, this value is never true,
> probably because of the opengl provider chaos that surrounds the vout's.
> I verified this, by checking with var_GetBool( p_vout, "fullscreen" ), if
> this fixes the problem and it does.
Not accessing p_vout field directly is the right thing (ie using
var_GetBool( p_vout, "fullscreen" )).
> I'm not sure what the desired behaviour even is actually. When do we
> want to show these 'sliders' ?
I think when thoses checks were added they meant : show the OSD when fullscreen
or when there is no graphical interface (providing embed video was an 'indication').
More information about the vlc-devel