[vlc-devel] RE : [PATCH] -- correct broken URI for Windows(trac#2843)

Rémi Denis-Courmont remi at remlab.net
Thu Jun 11 10:14:55 CEST 2009

On Thu, 11 Jun 2009 09:33:42 +0200, "brezhoneg1" <brezhoneg1 at yahoo.fr>
> Make_URI is a bit misleading (only used twice and designed for path and
> filename only). I propose the following :
>           - rename make_URI into encode_URI_path 
>           - create the opposite decode_URI_path

That is just as misleading. make_URI() makes an URI from a path. Using
encode would reinforce the confusion that you can "encode URIs", which is a
(widely held to be true) _myth_.

> btw, decode_URI is also a bit misleading, because the opposite function
> is in fact encode_URI_component, and both cannot work for path on
> Windows

They cannot work on ANY operating systems when it comes to handling paths.
This is in no way specific to Windows.

decode_URI is really individual decoding URI *components*. The name is for
historical reason. I don't want to fix it (myself) because I don't want to
see what horror bugs we have to have in URI handling code here and there.
Go ahead _if_ you know what you are doing. But while I don't mean to be
rude, it looks, from your patch, like you don't know.

Rémi Denis-Courmont

More information about the vlc-devel mailing list