[vlc-devel] [PATCH] Enable aspectratio parameter in mozillaplugin

[jean-paul.saman at planet.nl]

On Wed, Jun 10, 2009 at 1:29 PM, Vicente Jiménez<googuy at gmail.com> wrote:
> Thanks for the review!
>
> I've suposed it was C++ code because of the file extension. I was
> looking for similar parameter operations in the code but found none
> and I supposed that the concatenation could be done with +. Thanks for
> the clarifications.
>
> You mean to do:
>            ppsz_argv[ppsz_argc++] = "--aspect-ratio";
>            ppsz_argv[ppsz_argc++] = argv[i];
>
> Is this correct?
>
No it isn't correct. This patch opens a can of worms.

The mozilla plugin has already support for specifying an aspect ration (vlc.video.aspectRatio). Please read the documentation on http://wiki.videolan.org/Documentation:WebPlugin#Building_HTML_pages_for_Mozilla.2FFirefox.2FInternet_Explorer.2FSafari.

gtz,
Jean-Paul Saman.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090611/02dcea54/attachment.html>