[vlc-devel] commit: libvlc vlm init fix Don't test p_vlm twice if it wasn' t NULL the first time Don't add the callback if the creation failed ( Sébastien Escudier )

[git version control]

vlc | branch: master | Sébastien Escudier <sebastien-devel at celeos.eu> | Fri Jun 12 16:54:48 2009 +0200| [e97c8b3668d04396e892ad80e9d5a33d1a72e24b] | committer: Rémi Denis-Courmont 

libvlc vlm init fix Don't test p_vlm twice if it wasn't NULL the first time Don't add the callback if the creation failed

Signed-off-by: Rémi Denis-Courmont <remi at remlab.net>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e97c8b3668d04396e892ad80e9d5a33d1a72e24b
---

 src/control/vlm.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/control/vlm.c b/src/control/vlm.c
index 824d57d..bbeb883 100644
--- a/src/control/vlm.c
+++ b/src/control/vlm.c
@@ -159,15 +159,16 @@ static int libvlc_vlm_init( libvlc_instance_t *p_instance,
     if( !p_instance->p_vlm )
     {
         p_instance->p_vlm = vlm_New( p_instance->p_libvlc_int );
+        if( !p_instance->p_vlm )
+        {
+            libvlc_exception_raise( p_exception,
+                                    "Unable to create VLM." );
+            return VLC_EGENERIC;
+        }
         var_AddCallback( (vlc_object_t *)p_instance->p_vlm, "intf-event", VlmEvent,
                          p_instance->p_event_manager );
     }
-    if( !p_instance->p_vlm )
-    {
-        libvlc_exception_raise( p_exception,
-                                "Unable to create VLM." );
-        return VLC_EGENERIC;
-    }
+
     return VLC_SUCCESS;
 }
 #define VLM_RET(p,ret) do {                                     \