[vlc-devel] commit: Fix a segfault if the mask can' t be loaded and aso fail imediately if the file ( Rémi Duraffort )
Rémi Duraffort
ivoire at videolan.org
Tue Jun 30 16:54:26 CEST 2009
> On Tue, Jun 30, 2009, git version control wrote:
> > + /* If the mask if empty return the picture */
> > + vlc_mutex_lock( &p_sys->lock );
> > + if( !p_sys->p_mask )
> > + {
> > + vlc_mutex_unlock( &p_sys->lock );
> > + return p_pic;
> > + }
> You must never do that with the current filter API.
> The picture allocator must be used for every picture returned.
So I have to allocate a new Picture (using filter_NewPicture) and return
using CopyInfoAndRelease ?
We must also fix the postproc filter which is doing the same (I copy
from it).
--
Rémi Duraffort | ivoire
More information about the vlc-devel
mailing list