[vlc-devel] commit: Fix a segfault if the mask can' t be loaded and aso fail imediately if the file ( Rémi Duraffort )

[Laurent Aimar]

On Tue, Jun 30, 2009, Rémi Duraffort wrote:
> > On Tue, Jun 30, 2009, git version control wrote:
> > > +    /* If the mask if empty return the picture */
> > > +    vlc_mutex_lock( &p_sys->lock );
> > > +    if( !p_sys->p_mask )
> > > +    {
> > > +        vlc_mutex_unlock( &p_sys->lock );
> > > +        return p_pic;
> > > +    }
> >  You must never do that with the current filter API.
> > The picture allocator must be used for every picture returned.
> So I have to allocate a new Picture (using filter_NewPicture) and return
> using CopyInfoAndRelease ?
 Yes (if they have the same size+chroma).

> We must also fix the postproc filter which is doing the same (I copy
> from it).
 Yes, thank you.

-- 
fenrir