[vlc-devel] [PATCH} --miscellaneous patches for skins and qt4

brezhoneg1 brezhoneg1 at yahoo.fr
Mon Mar 2 17:46:28 CET 2009


 

Please, find attached a series of small patches that correct skins/qt4
problems.

Patch1 :
Corrects crash when closing preferences dialog box with upper right
X-icon of the window and trying to open it again (both skins and qt4). (
When setAttribute( Qt::WA_DeleteOnClose ) is used, Widget is
automatically deleted. Since a static variable references it, it has to
be nullified. )

Patch2:
Corrects skins2 not terminating properly.
(Close function of the skin2 interface module was never called, because
qt4 dialog was still refcounting it).

Patch3:
Corrects Drag&Drop for skins on Linux (mrl was file:/mnt/.. with a
single slash instead of three).
Correction removes prefix (consistent with qt4 drag&drop and allows
images to also be dropped)

Patch4:
Corrects errors like "Xlib: unexpected async reply (sequence 0x9ca)"
that occur randomly and freeze the skins interface. 
Research on the web shows this error is related to multiple threads
using xlib within an application.
Solution seems to be the XInitThreads call, though it is unclear how qt4
behaves.
This patch indeed solved this problem (numerous tests), and did not seem
to create problem with the qt4 dialog.

Erwan10
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Corrects-crash-when-closing-preference-dialog-upper.patch
Type: application/octet-stream
Size: 954 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090302/91a58b41/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-corrects-drag-drop-for-skins-on-Linux-mrl-wrongly-i.patch
Type: application/octet-stream
Size: 1064 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090302/91a58b41/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Dialogs-destroy-move-from-the-Close-function-becaus.patch
Type: application/octet-stream
Size: 1297 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090302/91a58b41/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-make-sure-xlib-is-initialized-to-be-thread-safe.patch
Type: application/octet-stream
Size: 855 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090302/91a58b41/attachment-0003.obj>


More information about the vlc-devel mailing list