[vlc-devel] [PATCH} --miscellaneous patches for skins and qt4

Jean-Baptiste Kempf jb at videolan.org
Mon Mar 2 17:48:27 CET 2009

On Mon, Mar 02, 2009 at 05:46:28PM +0100, brezhoneg1 wrote :
> Patch1 :
> Corrects crash when closing preferences dialog box with upper right
> X-icon of the window and trying to open it again (both skins and qt4). (
> When setAttribute( Qt::WA_DeleteOnClose ) is used, Widget is
> automatically deleted. Since a static variable references it, it has to
> be nullified. )
Yeah, patch fine, but I am going to remove Prefs singleton, so it
doesn't really matter.

> Patch2:
> Corrects skins2 not terminating properly.
> (Close function of the skin2 interface module was never called, because
> qt4 dialog was still refcounting it).
Seems ok.

> Patch3:
> Corrects Drag&Drop for skins on Linux (mrl was file:/mnt/.. with a
> single slash instead of three).
> Correction removes prefix (consistent with qt4 drag&drop and allows
> images to also be dropped)

> Patch4:
> Corrects errors like "Xlib: unexpected async reply (sequence 0x9ca)"
> that occur randomly and freeze the skins interface. 
> Research on the web shows this error is related to multiple threads
> using xlib within an application.
> Solution seems to be the XInitThreads call, though it is unclear how qt4
> behaves.
> This patch indeed solved this problem (numerous tests), and did not seem
> to create problem with the qt4 dialog.

Xlib mess, I won't comment.

Best Regards,

Jean-Baptiste Kempf

More information about the vlc-devel mailing list