[vlc-devel] [PATCH] -- skins2 (more corrections)

[brezhoneg1]

This series of patch is an attempt to solve skins2 problems described in
trac http://trac.videolan.org/vlc/ticket/2204 and several issues that
prevent it from terminating nicely.


Patch1: answer to trac #2204
----------------------------

This patch features a vout manager for skins2 that does the following :

- video reparenting 
    1/ when theme changes
    2/ when active layout changes
    3/ when visibility parameter changes

- multiple video widgets within a single skins2 window
(e.g video and audio-visual can be displayed in the same window)

- As a window provider, all incoming vout requests are accepted.
(If there are not enough video widgets, the additional vouts are kept
hidden)
 

This patch has been tested successfully on both Linux(Ubuntu7.10) and
WinXP.
Yet, this is a first draft that certainly needs to be improved.



Patch2: xcommon.c
------------------
x11 vout plugin should wait for a DestroyNotify event before
terminating. Failure to do so can lead to Xlib BadWindow for the window
provider who may want to release its own resources just afterwards. 



Patch3: qt4 "p_input" management for main input manager.
-------------------------------------------------------
Several problems exist for this p_input :
- it is overwritten without caring if a reference was already held or
not.
- a vlc_object_release is misplaced
- a typo : p_input passed when NULL is obviously the right value 



patch4: qt4 missing vlc_object_release in menus (the easy way)
--------------------------------------------------------------
For want of a better solution, the patch just adds a missing
vlc_object_release to pair the vlc_object_hold in a menu.



Patch5: better termination for qt4
----------------------------------
This patch makes sure quit()is executed in the right thread (qt4 main
thread). That should remove the error: "QObject::killTimers: timers
cannot be stopped from another thread"



Patch6: DBUS is broken
----------------------
DBUS is broken right now (several lock issues with the playlist).
This patch just solves one issue (a quick workaround to overcome a
deadlock problem).



Erwan10
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-skins2-vout-manager.patch
Type: application/octet-stream
Size: 64854 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090315/60990db9/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-xcommon.c-make-sure-base-window-is-really-destroyed.patch
Type: application/octet-stream
Size: 1445 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090315/60990db9/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-qt4-correct-several-problems-related-to-p_input-mai.patch
Type: application/octet-stream
Size: 1585 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090315/60990db9/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-qt4-in-menus.cpp-missing-vlc_object_release.patch
Type: application/octet-stream
Size: 767 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090315/60990db9/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-at-qt4-termination-ensure-quit-function-is-execut.patch
Type: application/octet-stream
Size: 2984 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090315/60990db9/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-correct-lock-problem-since-playlist_CurrentInput-als.patch
Type: application/octet-stream
Size: 939 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090315/60990db9/attachment-0005.obj>