[vlc-devel] [PATCH] -- skins2 (more corrections)

[Rémi Denis-Courmont]

Le dimanche 15 mars 2009 02:49:23 brezhoneg1, vous avez écrit :
> patch4: qt4 missing vlc_object_release in menus (the easy way)
> --------------------------------------------------------------
> For want of a better solution, the patch just adds a missing
> vlc_object_release to pair the vlc_object_hold in a menu.

I fail to see how this solves anything. It does not make any sense to hold an 
object and then release with absolutely no synchronization in-between. 
Normally, you call _hold either from inside a lock, to keep the object past 
unlocking, or before you pass the object to another thread, or both.

To re-iterate, if vlc_object_release() works there, then the pair of 
vlc_object_hold()/vlc_object_release() is a no-op, and should both be 
removed. If the reference is needed, then the call to vlc_object_release() is 
too early and might cause a crash.

> Patch5: better termination for qt4
> ----------------------------------
> This patch makes sure quit()is executed in the right thread (qt4 main
> thread). That should remove the error: "QObject::killTimers: timers
> cannot be stopped from another thread"

What is calling quit() from the wrong thread? Maybe that's what should be 
fixed instead.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary