[vlc-devel] Potential memory leak in input control

Sébastien Escudier sebastien-devel at celeos.eu
Mon Mar 23 17:48:20 CET 2009


Hi

I think there can be a memory leak if INPUT_ADD_SUBTITLE is sent.
In src/input/control.c val.psz_string will be allocated, and sent with
input_ControlPush.
But if INPUT_CONTROL_SET_DIE is sent just after this, OR if
p_input->p->i_control >= INPUT_CONTROL_FIFO_SIZE, then this string will
never be free because the command will be lost.

Regards.






More information about the vlc-devel mailing list