[vlc-devel] Potential memory leak in input control

Laurent Aimar fenrir at via.ecp.fr
Mon Mar 23 20:58:45 CET 2009


On Mon, Mar 23, 2009, Sébastien Escudier wrote:
> I think there can be a memory leak if INPUT_ADD_SUBTITLE is sent.
> In src/input/control.c val.psz_string will be allocated, and sent with
> input_ControlPush.
> But if INPUT_CONTROL_SET_DIE is sent just after this, OR if
> p_input->p->i_control >= INPUT_CONTROL_FIFO_SIZE, then this string will
> never be free because the command will be lost.
 Yes, you are right, [c6a829aee766be1561ac1ee403de7dd15ab932ae] should fix it.

Thanks for noticing it.


More information about the vlc-devel mailing list