[vlc-devel] RE : [PATCH] -- fake-file-reload measured inmilliseconds instead of seconds

[brezhoneg1]

> -----Message d'origine-----
> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de Christophe Mutricy
> Envoyé : lundi 30 mars 2009 14:53
> À : Mailing list for VLC media player developers
> Objet : Re: [vlc-devel] [PATCH] -- fake-file-reload measured
> inmilliseconds instead of seconds
> 
> 2009/3/30 brezhoneg1 <brezhoneg1 at yahoo.fr>:
> >
> > In module/codec/fake.c, all time parameters but fake-file-reload are
> > measured in milliseconds. For the latter one, millisecond should
also be
> > more appropriate than second as the unit of time. (see trac #2295)
> >
> > This patch just changes fake-file-reload from sec to millisec.
> 
> What's wrong with using float like suggested in the ticket ?

Nothing's wrong with float.

millisecond just makes things a bit more consistent with existing
parameters
(fake-duration is already measured in milliseconds). At least, now
everything related to time within fake is measured in the same unit.

But, if float is seen as a better solution, I can rewrite the patch with
float.

> 
> If we change from seconds to milliseconds we will break the command
> lines and scripts of our users.
> 
> If we really don't want to use float, we should document the change in
> NEWS

Yes, if millisecond were chosen, it would better to do the change before
the vlc1.0 is released and document it in NEWS, since users would have
to add 000 into their scripts.



Erwan10