[vlc-devel] RE : [PATCH] -- fake-file-reload measured inmilliseconds instead of seconds

Antoine Cellerier dionoea at videolan.org
Tue Mar 31 10:31:12 CEST 2009


On Mon, Mar 30, 2009, brezhoneg1 wrote:
> > What's wrong with using float like suggested in the ticket ?
> 
> Nothing's wrong with float.
> 
> millisecond just makes things a bit more consistent with existing
> parameters
> (fake-duration is already measured in milliseconds). At least, now
> everything related to time within fake is measured in the same unit.
> 
> But, if float is seen as a better solution, I can rewrite the patch with
> float.

Seconds seem better than milliseconds to me. So yeah, if anything were
to change, I'd rather change the milliseconds options to seconds (in
floats so we keep the possibility to have sub second accuracy).

-- 
Antoine Cellerier
dionoea



More information about the vlc-devel mailing list