[vlc-devel] [PATCH] -- skins2: workaround to possible hangings with xlib

brezhoneg1 brezhoneg1 at yahoo.fr
Sun May 24 21:33:32 CEST 2009

New skins2 tests have been performed on a freshly installed Debian5.0
with QT4.4.3. 

Here are some feedbacks :

- Unlike Ubuntu7.10, skins2 very often (but not always) hangs when
starting a new input. An expected MapNotify event fails to occur. In the
attached patch, a counter has been added to get out of an infinite loop
in case this happens. This (rather ugly) workaround makes it possible to
use skins2 on Debian quite satisfactorily. In the long run, rewriting
skins2 with xcb could be a good thing as X11 is really a whimsical thing
in a multi-threaded context.

- Latest ffmpeg repository (svn) really is not skins2-friendly (half the
bitmaps failed to be displayed as expected ...). I had to retrieve an
old ffmpeg (one month old) to get back good-looking skins2.

- valgrind shows several "invalid read" in the libswcale and the qt4
libraries. And vlc sometimes crashes at termination time. (to be

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-skins2-X11-correct-possible-hanging-at-the-xlib-l.patch
Type: application/octet-stream
Size: 1515 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090524/83cae74b/attachment.obj>

More information about the vlc-devel mailing list