[vlc-devel] [PATCH] Add deinterlacing to libvlc, moz-plugin and activeX

Pierre d'Herbemont pdherbemont at free.fr
Wed May 27 18:50:42 CEST 2009


On Wed, May 27, 2009 at 9:48 AM, Pierre d'Herbemont <pdherbemont at free.fr> wrote:
> On Wed, May 27, 2009 at 2:13 AM, Cyril MATHE
> <cmathe at actech-innovation.com> wrote:
>> Three patches which add deinterlacing in libvlc
>> (libvlc_video_enable_deinterlace), in moz-plugin and activeX
>
> The prototype doesn't match the rest of libvlc, libvlc_exception_t
> should be at the end.
>
> +void libvlc_video_enable_deinterlace(libvlc_media_player_t *p_mi,
> +                            libvlc_exception_t *p_e, int b_enable,
> char *psz_option)
>
> Also, I would name it libvlc_video_set_deinterlace();

And given that the last parameter is not optional, it shouldn't be
named psz_option.

Pierre.



More information about the vlc-devel mailing list