[vlc-devel] [PATCH] Add deinterlacing to libvlc, moz-plugin and activeX

[Cyril MATHE]

Le mercredi 27 mai 2009 à 09:48 -0700, Pierre d'Herbemont a écrit :

> The prototype doesn't match the rest of libvlc, libvlc_exception_t
> should be at the end.
> 
> +void libvlc_video_enable_deinterlace(libvlc_media_player_t *p_mi,
> +                            libvlc_exception_t *p_e, int b_enable,
> char *psz_option)
> 
> Also, I would name it libvlc_video_set_deinterlace();

I will change it.

> And given that the last parameter is not optional, it shouldn't be
> named psz_option.

psz_option don't mean that this parameter is optional, but that we have
to choose the deinterlace option (mode will be more adapted). If it
disturbs you, I can call it psz_mode.

Le mercredi 27 mai 2009 à 17:44 +0300, Rémi Denis-Courmont a écrit :
 
> 0001 looks correct, but why do you use var_Set() instead of
var_SetString() 
> and what's the point of the psz_filter_type variable?

	I use var_Set because in deinterlace.c, OpenFilter get the deinterlace
parameters by a var_Get, and I used var_Set if I had more parameters to
add to val. For the moment I just use a string, but I prefer to keep a
var_Set in case of I need it later. 
	
	The problem with psz_filter_type variable is special. In deinterlace.c
there is two type of video filters : "video filter" and "video filter2".
The easier to use is "video filter2" and in addition there is no black
screen whan we set deinterlace with it (which is not the case with
"video filter"). In deinterlace.c you can see a part call video filter2
function, and if you look at it you can see that bob and linear filter
are not implemented. Discard and mean are not working but I don't know
why.