[vlc-devel] [BUG] include/vlc_block.h declares block_FifoPace but does not export it

Rémi Denis-Courmont remi at remlab.net
Mon Nov 2 09:28:25 CET 2009


On Fri, 30 Oct 2009 18:05:55 PDT, Nick Briggs <briggs at parc.com> wrote:
> The function block_FifoPace was introduced recently (> 0.9.9), but in
> include/vlc_block.h (1.0.2, 1.0.3-rc) we find:
> 
> VLC_EXPORT( void,           block_FifoRelease,  ( block_fifo_t * ) );
> /* TODO: do we need to export this? */
> void block_FifoPace (block_fifo_t *fifo, size_t max_depth, size_t
> max_size);
> VLC_EXPORT( void,           block_FifoEmpty,    ( block_fifo_t * ) );
> 
> I believe the answer to the question is *yes*, because if it's not
> exported it's not available in the library on Mac OSX, and perhaps
others.

That does not answer the question. At the time I introduced the function
block_FifoPace() was not called from anywhere outside libvlccore. So it did
not need to be exported, unless I missed something.

So why do you want to export it anyway?

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list