[vlc-devel] [BUG] include/vlc_block.h declares block_FifoPace but does not export it

[Nick Briggs]

Rémi --
[Sorry I didn't catch your reply sooner]

I'm using the block_Fifo* functions from an access module, compiled as a 
VLC plugin,  that interfaces with PARC's Content-Centric Networking 
transport (http://www.ccnx.org).  I need some buffering between the CCN 
packet input thread and the stream of the upstream reader, and the 
block_Fifo functions are designed for exactly that.   block_FifoPace is 
exactly the functionality I need to cleanly limit the fifo size without 
resorting to spinning on the fifo depth.  Since all the block_Fifo 
functions are already exported (except block_FifoSize and 
block_FifoPace) I made the request...

Any other info I can provide?

                \nick

> On Fri, 30 Oct 2009 18:05:55 PDT, Nick Briggs <briggs <at> parc.com> wrote:
> > The function block_FifoPace was introduced recently (> 0.9.9), but in
> > include/vlc_block.h (1.0.2, 1.0.3-rc) we find:
> > 
> > VLC_EXPORT( void,           block_FifoRelease,  ( block_fifo_t * ) );
> > /* TODO: do we need to export this? */
> > void block_FifoPace (block_fifo_t *fifo, size_t max_depth, size_t
> > max_size);
> > VLC_EXPORT( void,           block_FifoEmpty,    ( block_fifo_t * ) );
> > 
> > I believe the answer to the question is **yes**, because if it's not
> > exported it's not available in the library on Mac OSX, and perhaps
> others.
>
> That does not answer the question. At the time I introduced the function
> block_FifoPace() was not called from anywhere outside libvlccore. So it did
> not need to be exported, unless I missed something.
>
> So why do you want to export it anyway?
>
> -- 
> Rémi Denis-Courmont
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091108/9bef27a6/attachment.html>