[vlc-devel] [PATCH] GSoC: lua services discovery, core part

[Pierre d'Herbemont]

On Sun, Nov 8, 2009 at 9:18 PM, Fabio Ritrovato <exsephiroth87 at gmail.com> wrote:
> 2) The 3 new functions that are used to comunicate with SDs, ItemPut
> is used to send data (a string) to an SD, that parses it and add to
> itself (examples: for MTP, you pass a file path and the file is added
> to the device, for youtube, you pass strings with search data, like
> keywords, categories, and it create a node with the videos you want,
> etc), ItemGet is to get items from an SD (example: MTP you transfer
> files from a device to your hard disk), ItemDelete is the same, but it
> deletes items...

You should add this as a comment somewhere near those functions, as it
is not obvious.


I won't bother much with the naming, yet here are my suggestions, feel
free to use them or drop them:

> +    int (*pf_item_put) ( services_discovery_t *, const char * );

pf_add_query()
(BTW, there is no remove?)

> +    int (*pf_item_get) ( services_discovery_t *, const char *, input_item_t * );

pf_get_items_for_query()
What is the third parameter, is it a node where the items will be
added? This probably needs more details.

> +    int (*pf_item_delete) ( services_discovery_t *, input_item_t * );

pf_delete_item()

Thanks!

Pierre.