[vlc-devel] [PATCH] GSoC: lua services discovery, core part

[Fabio Ritrovato]

> I won't bother much with the naming, yet here are my suggestions, feel
> free to use them or drop them:

Those names where suggested last year, so I kept them, but anyone
that's fine with you is fine with me :)

>> +    int (*pf_item_put) ( services_discovery_t *, const char * );
>
> pf_add_query()
> (BTW, there is no remove?)

Remove of what?
ItemDelete is to remove items...

>> +    int (*pf_item_get) ( services_discovery_t *, const char *, input_item_t * );
>
> pf_get_items_for_query()
> What is the third parameter, is it a node where the items will be
> added? This probably needs more details.

The third parameter is the item you want to get, the second parameter
is usually the path were you want the item to be saved...

>> +    int (*pf_item_delete) ( services_discovery_t *, input_item_t * );
>
> pf_delete_item()

Why not put_item and get_item then?
What's the query for?