[vlc-devel] [PATCH] GSoC: lua services discovery, core part

[Pierre d'Herbemont]

On Mon, Nov 9, 2009 at 1:47 AM, Fabio Ritrovato <exsephiroth87 at gmail.com> wrote:
>> I won't bother much with the naming, yet here are my suggestions, feel
>> free to use them or drop them:
>
> Those names where suggested last year, so I kept them, but anyone
> that's fine with you is fine with me :)
>
>>> +    int (*pf_item_put) ( services_discovery_t *, const char * );
>>
>> pf_add_query()
>> (BTW, there is no remove?)
>
> Remove of what?

Remove the item added by add_query().

I would pair it with a remove() for consistency, or have the resulting
input_item returned somehow.

> ItemDelete is to remove items...
>
>>> +    int (*pf_item_get) ( services_discovery_t *, const char *, input_item_t * );
>>
>> pf_get_items_for_query()
>> What is the third parameter, is it a node where the items will be
>> added? This probably needs more details.
>
> The third parameter is the item you want to get, the second parameter
> is usually the path were you want the item to be saved...

Oh. Ok. That's particularly unclear regarding what is what. That needs
to be in the comment as well. And in the argument list.

pf_export_item_to_path() would seem more appropriate.

>
>>> +    int (*pf_item_delete) ( services_discovery_t *, input_item_t * );
>>
>> pf_delete_item()

That said, some item may be removable, some other not. How do you track this?

> Why not put_item and get_item then?

Sure.

Thanks for the clarifications!

Pierre.