[vlc-devel] [PATCH] GSoC: lua services discovery, core part

[Jakob Leben]

On Tue, Nov 10, 2009 at 8:43 PM, Fabio Ritrovato <exsephiroth87 at gmail.com>wrote:

> On Tue, Nov 10, 2009 at 8:58 AM, Pierre d'Herbemont <pdherbemont at free.fr>
> wrote:
> > I am still concerned because put_item() doesn't take an input item but
> > a string. That string is a query. And in the end it might put a list
> > of input_item. Can we clarify this?
>
> Ok, I think I get what you meant, correct me if I'm wrong, but you're
> just saying that since I'm passing a string, and not an actual item,
> using put_item() can be misleading, right?
> If that's so, add_query() is perfectly fine with me (or is add_string()
> better?


Hi,

If I got you right, Fabio, the string that is passed to put_item is expected
to be an URI (also a filename) and the action is expected to do some kind of
transfer of an object (file...) under that URI to the location controlled by
the SD module. Is that right?

If that is the case, than IMHO everything should be much more documented and
the function names even more expressive to tell that there will actually be
modifications done to the state of the service provider / local filesystem,
instead of just information passing.

Best regards,
Jakob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091110/1ebbc5af/attachment.html>