[vlc-devel] [PATCH] V4L for FreeBSD userland libv4l{1, 2} wrapper library

[Rafaël Carré]

On Tue, 17 Nov 2009 13:43:41 +0800
Buganini <buganini at gmail.com> wrote:

> Patch for configure.ac here
> http://zeta.twbbs.org/~buganini/git-configure.ac.patch
> 
> tested on my laptop.

 dnl
+dnl libv4l1 support for video4linux.
+dnl
+AC_ARG_ENABLE( libv4l,
+  [  --enable-libv4l        Libv4l Video4Linux support (default
 enabled)]) +if test "${enable_libv4l}" != "no" -a "${enable_v4l}" !=
 "no" +then
+    PKG_CHECK_MODULES( LIBV4L, libv4l1, [
+      VLC_ADD_LDFLAGS([v4l],[${LIBV4L_LIBS}])
+      VLC_ADD_CFLAGS([v4l],[${LIBV4L_CFLAGS}])
+      AC_CHECK_LIB(v4l1, v4l1_open, [

Why do you need to check for v4l1_open ?

-      AC_DEFINE(HAVE_LIBV4L2, 1, Define if libv4l is available)],
+      AC_CHECK_LIB(v4l2, v4l2_open, [
+        AC_DEFINE(HAVE_LIBV4L2, 1, Define if v4l2_open is available)
+      ])
+      AC_DEFINE(HAVE_LIBV4L2, 1, Define if libv4l2 is available)],

Same question, is v4l2_open() not in linux libv4l2 ?

Also you define 2 times LIBV4L2 while it should be LIBV4L2_OPEN if i
understand correctly

Rest of the patch looks ok, please send a version merged with your
previous diffs, formatted with git format-patch is better so you can
keep authorship of the commit

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091117/30941df1/attachment.sig>