[vlc-devel] [PATCH] V4L for FreeBSD userland libv4l{1, 2} wrapper library

[Buganini]

Ah, they exist.  v4l2.c is using utf8_open() directly, I thought they
dont exist.

http://zeta.twbbs.org/~buganini/0001-v4l2-use-v4l2_open-for-use-of-libv4l2.patch
http://zeta.twbbs.org/~buganini/0002-v4l-support-libv4l.patch

--Buganini

On Tue, Nov 17, 2009 at 2:38 PM, Rafaël Carré <rafael.carre at gmail.com> wrote:
> On Tue, 17 Nov 2009 13:43:41 +0800
> Buganini <buganini at gmail.com> wrote:
>
>> Patch for configure.ac here
>> http://zeta.twbbs.org/~buganini/git-configure.ac.patch
>>
>> tested on my laptop.
>
>  dnl
> +dnl libv4l1 support for video4linux.
> +dnl
> +AC_ARG_ENABLE( libv4l,
> +  [  --enable-libv4l        Libv4l Video4Linux support (default
>  enabled)]) +if test "${enable_libv4l}" != "no" -a "${enable_v4l}" !=
>  "no" +then
> +    PKG_CHECK_MODULES( LIBV4L, libv4l1, [
> +      VLC_ADD_LDFLAGS([v4l],[${LIBV4L_LIBS}])
> +      VLC_ADD_CFLAGS([v4l],[${LIBV4L_CFLAGS}])
> +      AC_CHECK_LIB(v4l1, v4l1_open, [
>
> Why do you need to check for v4l1_open ?
>
> -      AC_DEFINE(HAVE_LIBV4L2, 1, Define if libv4l is available)],
> +      AC_CHECK_LIB(v4l2, v4l2_open, [
> +        AC_DEFINE(HAVE_LIBV4L2, 1, Define if v4l2_open is available)
> +      ])
> +      AC_DEFINE(HAVE_LIBV4L2, 1, Define if libv4l2 is available)],
>
> Same question, is v4l2_open() not in linux libv4l2 ?
>
> Also you define 2 times LIBV4L2 while it should be LIBV4L2_OPEN if i
> understand correctly
>
> Rest of the patch looks ok, please send a version merged with your
> previous diffs, formatted with git format-patch is better so you can
> keep authorship of the commit
>
> --
> Rafaël Carré
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
>