[vlc-devel] [PATCH] V4L for FreeBSD userland libv4l{1, 2} wrapper library

[Buganini]

> -static const __u32 p_chroma_fallbacks[] =
> +static const uint32_t p_chroma_fallbacks[] =
>
> - This change is not mentioned in the patch, is it needed at all?

FreeBSD doesn't have that type definition, uint32_t is in C99
standard, both Linux and FreeBSD have it.


>
> - Did you see how libv4l2 support can be disabled at runtime to use
> (linux?) kernel support instead?

I added a function pointer
http://zeta.twbbs.org/~buganini/vlc/0001-v4l2-use-v4l2_open-for-use-of-libv4l2.patch
http://zeta.twbbs.org/~buganini/vlc/0002-v4l-support-libv4l.patch


>
> - I see v4l2_fd_open() is used in v4l2.c but no mention of "v4l2_open".
>
> I'm not sure to understand how this patch is specific to FreeBSD, I
> couldn't find the libv4l2 for linux source.
>
> - Is the libv4l2 you use a patched version of the already existing
> library, or a new library written from scratch?

the lib is: http://linuxtv.org/hg/v4l-dvb/file/e341e9e85af2/v4l2-apps/libv4l/libv4l2/libv4l2.c
v4l2_fd_open is defferent from v4l2_open.



--Buganini