[vlc-devel] [PATCH] V4L for FreeBSD userland libv4l{1, 2} wrapper library

[Rafaël Carré]

On Tue, 17 Nov 2009 20:07:43 +0800
Buganini <buganini at gmail.com> wrote:

> > -static const __u32 p_chroma_fallbacks[] =
> > +static const uint32_t p_chroma_fallbacks[] =
> >
> > - This change is not mentioned in the patch, is it needed at all?
> 
> FreeBSD doesn't have that type definition, uint32_t is in C99
> standard, both Linux and FreeBSD have it.

Ok

> > - Did you see how libv4l2 support can be disabled at runtime to use
> > (linux?) kernel support instead?
> 
> I added a function pointer

Why not the same way the other function pointers are stored? (as p_sys
members)

> http://zeta.twbbs.org/~buganini/vlc/0001-v4l2-use-v4l2_open-for-use-of-libv4l2.patch

I asked this more to know if v4l2 is available with kernel open/ioctl,
and I see it's available so the code will be the same for Linux /
FreeBSD

> http://zeta.twbbs.org/~buganini/vlc/0002-v4l-support-libv4l.patch

Thanks, this one is applied

> > - I see v4l2_fd_open() is used in v4l2.c but no mention of
> > "v4l2_open".
> >
> > I'm not sure to understand how this patch is specific to FreeBSD, I
> > couldn't find the libv4l2 for linux source.
> >
> > - Is the libv4l2 you use a patched version of the already existing
> > library, or a new library written from scratch?
> 
> the lib is:
> http://linuxtv.org/hg/v4l-dvb/file/e341e9e85af2/v4l2-apps/libv4l/libv4l2/libv4l2.c
> v4l2_fd_open is defferent from v4l2_open.

Thanks

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091117/c713373b/attachment.sig>