[vlc-devel] Support of events in Mozilla plugin - Beta
jpd at videolan.org
jpd at videolan.org
Thu Nov 19 11:02:47 CET 2009
On Wed, Nov 18, 2009 at 02:38:25PM +0100, Yannick Br?hon wrote:
> > 3) You methods/lists of type vector, but nowhere in the code you use
> > that fact to your benefit.
>
> what do you mean by this? The fact that it is a vector allows for fast
> push_back operations and easy iterations, which is what is really
> needed here and guided this choice. What would you suggest otherwise?
We discussed it so I can answer: I already noted that <map> wasn't
needed, jpsaman thought <vector> wasn't needed either but you do use it.
I think I already mentioned that the eventlisteners vector is fine but
the eventlist vector needs to change from NPUTF* to libvlc_event_type_t.
More information about the vlc-devel
mailing list