[vlc-devel] commit: svg: quick fix for out-of-tree compilation (Olivier Aubert )
olivier.aubert at liris.cnrs.fr
Tue Nov 24 15:57:36 CET 2009
Relax... There is no out-of-tree build system, just a gcc command-line.
I could add the define in there, if it makes you feel better, but I fail
to see why you consider this as such a big issue. In what way does it
impact the quality of the code?
It just helps the - maybe bogus in your eyes - scenario of compiling
modules without configuring the whole VLC. Indeed, it could cause
issues, since config.h data is not available (and if provided from
elsewhere, could be incorrect). But in this specific case, I know that I
do not have other dependencies.
That said, I would be more than happy to replace this by a patch that
enables the default compilation and inclusion in binary distributions of
the svg plugin. This way, I would not have to compile it myself to get
it for my application.
On Tue, 2009-11-24 at 15:49 +0100, Rémi Denis-Courmont wrote:
> On Tue, 24 Nov 2009 15:30:27 +0100, jpd at videolan.org wrote:
> >> ...then HAVE_CONFIG_H is not defined so there is no problem.
> > If you then have to #else,
> The point is, you don't need #else. This commit is bogus.
> If you want to do that anyway, it's your out-of-tree build system's problem
> to get the necessary macros defined. That includes gettext macros, just
> like any other define from config.h or vlc_fixups.h. You can either provide
> your own config.h or use CPP flags.
> With that said, this commit should be reverted.
More information about the vlc-devel