[vlc-devel] commit: svg: quick fix for out-of-tree compilation (Olivier Aubert )

[Rémi Denis-Courmont]

On Tue, 24 Nov 2009 15:57:36 +0100, Olivier Aubert
<olivier.aubert at liris.cnrs.fr> wrote:
> Relax... There is no out-of-tree build system, just a gcc command-line.
> I could add the define in there, if it makes you feel better, but I fail
> to see why you consider this as such a big issue. In what way does it
> impact the quality of the code?

If every body starts adding custom build-specific hacks in the official
tree, I have to doubt that the quality of the code improves. Why just SVG?
Where does it stop?

> It just helps the - maybe bogus in your eyes - scenario of compiling
> modules without configuring the whole VLC.

The scenario is not bogus. The way you're implementing it is.

> That said, I would be more than happy to replace this by a patch that
> enables the default compilation and inclusion in binary distributions of
> the svg plugin. This way, I would not have to compile it myself to get
> it for my application.

The official tree is not the place to fix distribution packages. If you
want more plugins enabled, complain to the packager.

-- 
Rémi Denis-Courmont