[vlc-devel] commit: svg: quick fix for out-of-tree compilation (Olivier Aubert )

Rémi Denis-Courmont remi at remlab.net
Tue Nov 24 16:51:37 CET 2009


Le mardi 24 novembre 2009 17:31:14 jpd at videolan.org, vous avez écrit :
> That said, I don't believe it is sensible to conditionally include
> config.h if without it the includers won't compile. The conditional
> means that the implicit promise that it will compile without a config.h
> is simply not true. This promise either should be fulfilled or it should
> not be made in the first place.

There are two ways that the (autoconf) system can communicate 'settings'. One 
is via a configuration header - then it defines HAVE_CONFIG_H in CPPFLAGS. 
Alternatively, it can set every thing via CPPFLAGS, and the HAVE_CONFIG_H is 
not defined.

That's all. VLC is just following the autoconf conventions. Nobody promised 
that anything would compile out of the box.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list