[vlc-devel] [Patch] Correcting potential crash in audio bandlimited resampler

Hugo Beauzee-Luyssen beauze.h at gmail.com
Sat Nov 28 13:46:33 CET 2009


On Wed, Nov 25, 2009 at 6:34 PM, Rafaël Carré <rafael.carre at gmail.com> wrote:
> On Thu, 19 Nov 2009 12:22:01 +0100
> Hugo Beauzee-Luyssen <beauze.h at gmail.com> wrote:
>
>> +        p_filter->fmt_in.audio.i_bytes_per_frame =
>> +                p_filter->fmt_in.audio.i_channels *
>> +                p_filter->fmt_in.audio.i_bitspersample / 8;
>
> That would be the number of bytes per sample, not per frame
>
> Instead perhaps the block size could be used? (I didn't read
> bandlimited code)
>

Maybe... I don't really know that part of the code, and I'm kinda lost :/
However you're right, that wouldn't be the bytes per sample... I think
I'll try to write the patch again in the next days.

-- 
Hugo Beauzée-Luyssen



More information about the vlc-devel mailing list