[vlc-devel] [Patch] Correcting potential crash in audio bandlimited resampler

[Hugo Beauzee-Luyssen]

On Sat, Nov 28, 2009 at 1:46 PM, Hugo Beauzee-Luyssen
<beauze.h at gmail.com> wrote:
> On Wed, Nov 25, 2009 at 6:34 PM, Rafaël Carré <rafael.carre at gmail.com> wrote:
>> On Thu, 19 Nov 2009 12:22:01 +0100
>> Hugo Beauzee-Luyssen <beauze.h at gmail.com> wrote:
>>
>>> +        p_filter->fmt_in.audio.i_bytes_per_frame =
>>> +                p_filter->fmt_in.audio.i_channels *
>>> +                p_filter->fmt_in.audio.i_bitspersample / 8;
>>
>> That would be the number of bytes per sample, not per frame
>>
>> Instead perhaps the block size could be used? (I didn't read
>> bandlimited code)
>>
>
> Maybe... I don't really know that part of the code, and I'm kinda lost :/
> However you're right, that wouldn't be the bytes per sample... I think
> I'll try to write the patch again in the next days.
>

FYI:

Regards,

-- 
Hugo Beauzée-Luyssen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: output
Type: application/octet-stream
Size: 3041 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091129/08346d85/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: backtrace
Type: application/octet-stream
Size: 1730 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091129/08346d85/attachment-0001.obj>