[vlc-devel] commit: Increased fifo decoder size to 400mb. (Laurent Aimar )

[Laurent Aimar]

Hi,

On Sat, Oct 24, 2009, Rémi Denis-Courmont wrote:
> Le samedi 24 octobre 2009 10:17:35 Laurent Aimar, vous avez écrit :
> >  This commit does not really change VLC requirement, it just lets VLC play
> >  more valid files (provided you have more memory than 50 MB).
> 
> Well it does. Previously VLC would not exceed 40 Mb per E/S.
 It does only when it is needed, so it doesn't change for the files that
used to play.

> 500 Mb (or no limits) is a lot more likely to bring into a thrashing hell and 
> basically crash than 40 Mb. Regardless of how much physical memory the system 
> has, and how much is free, 40 Mb is a much more reasonable amount of data put 
> to the swap than 500 Mb.
 Have you ever seen it in action... ?
 There is a lot of place where we don't limit memory usage, this one is an
exception. The only time I have seen it being activated, is on valid files
(raw video), on really high caching values, and when I was working on the
core (bugs in input/codec).

> >  As there is no really good fixed value, I simply but a very large one
> >  (mainly for devs working on the input/decoder).
> 
> No. 40 Mb was a good value. Something is seriously wrong if you need to cache 
> 500 Mb of coded data on a single E/S, even at HD resolutions.
 I increased it because 40 Mb is too low (typically with raw HD video), now 400Mb
may be a bit too high, but I don't want to break the playback of valid files.

-- 
fenrir