[vlc-devel] commit: qt4: use longname to search activated input-item (Ilkka Ollakka )

git version control git at videolan.org
Sun Oct 25 13:36:52 CET 2009


vlc | branch: master | Ilkka Ollakka <ileoo at iki.fi> | Sun Oct 25 14:36:06 2009 +0200| [edcc45df28099534938f04f26b573449c5c897bf] | committer: Ilkka Ollakka 

qt4: use longname to search activated input-item

Should fix #3112 and maybe make it littlebit cleaner (hopefully)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=edcc45df28099534938f04f26b573449c5c897bf
---

 modules/gui/qt4/components/playlist/selector.cpp |   13 ++++++-------
 modules/gui/qt4/components/playlist/selector.hpp |    1 +
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/modules/gui/qt4/components/playlist/selector.cpp b/modules/gui/qt4/components/playlist/selector.cpp
index 42076f9..7bb9cd3 100644
--- a/modules/gui/qt4/components/playlist/selector.cpp
+++ b/modules/gui/qt4/components/playlist/selector.cpp
@@ -82,23 +82,21 @@ void PLSelector::setSource( QTreeWidgetItem *item )
         if( !playlist_IsServicesDiscoveryLoaded( THEPL, qtu( qs ) ) )
         {
             playlist_ServicesDiscoveryAdd( THEPL, qtu( qs ) );
-#warning FIXME
-            playlist_item_t *pl_item =
-                    THEPL->p_root_category->pp_children[THEPL->p_root_category->i_children-1];
-            item->setData( 0, PPL_ITEM_ROLE, QVariant::fromValue( pl_item ) );
 
-            emit activated( pl_item );
-            return;
         }
     }
 
     if( i_type == SD_TYPE )
         msg_Dbg( p_intf, "SD already loaded, reloading" );
 
+    playlist_Lock( THEPL );
     playlist_item_t *pl_item =
-            item->data( 0, PPL_ITEM_ROLE ).value<playlist_item_t *>();
+            playlist_ChildSearchName( THEPL->p_root_onelevel, qtu( item->data(0, LONGNAME_ROLE ).toString() ) );
+    playlist_Unlock( THEPL );
     if( pl_item )
             emit activated( pl_item );
+    else
+            msg_Info( p_intf, "no node found for %s", qtu( item->data(0, LONGNAME_ROLE ).toString() ) );
 }
 
 void PLSelector::createItems()
@@ -135,6 +133,7 @@ void PLSelector::createItems()
         sd_item = new QTreeWidgetItem( QStringList( qfu(*ppsz_longname) ) );
         sd_item->setData( 0, TYPE_ROLE, SD_TYPE );
         sd_item->setData( 0, NAME_ROLE, qfu( *ppsz_name ) );
+        sd_item->setData( 0, LONGNAME_ROLE, qfu( *ppsz_longname ) );
         sd_item->setFlags( sd_item->flags() & ~Qt::ItemIsDropEnabled );
         sds->addChild( sd_item );
         free( *ppsz_name );
diff --git a/modules/gui/qt4/components/playlist/selector.hpp b/modules/gui/qt4/components/playlist/selector.hpp
index f0471a3..758b35e 100644
--- a/modules/gui/qt4/components/playlist/selector.hpp
+++ b/modules/gui/qt4/components/playlist/selector.hpp
@@ -48,6 +48,7 @@ enum {
     TYPE_ROLE = Qt::UserRole,
     PPL_ITEM_ROLE,
     NAME_ROLE,
+    LONGNAME_ROLE,
 };
 
 Q_DECLARE_METATYPE( playlist_item_t *);




More information about the vlc-devel mailing list