[vlc-devel] [PATCH] Report RTP packet loss and be more silent during PIM Asserts

[Marian Ďurkovič]

On Thu, Sep 03, 2009 at 06:46:27PM +0300, Rémi Denis-Courmont wrote:
> Le jeudi 3 septembre 2009 18:37:19 Marian Ďurkovič, vous avez écrit :
> > Unreliability is the reason - for clean duplicates, I get "late packet"
> > message warning in 50 % of cases, since the previous copy was already
> > dequeued. And during PIM Assert the duplicates are shifted in time and thus
> > all are "late".
> >
> > One PIM Assert triggers about 500 duplicates misreported as "late" packets
> > at warning level. And it happens once per 3 minutes...
> 
> How does that require to pass the duplicates to the decoder thread? I mean, 
> isn't the second patch chunk sufficient?

Yes, sure it is. If you prefer to drop *some* duplicates earlier, don't apply the
first chunk, but keep in mind most duplicates will be passed further anyway.

BTW, we still have a bug with sequence wrap in rtp_queue(). Packet with RTPSeq=0
gets inserted before packet with RTPSeq=65535 (if it's still in queue)
which results in:

rtp demux debug: ignoring late packet (sequence: 65535)



    With kind regards,

         M.