[vlc-devel] [PATCH] Report RTP packet loss and be more silent during PIM Asserts

[Marian Ďurkovič]

On Thu, 3 Sep 2009 18:14:20 +0200, Marian Ďurkovič wrote
> BTW, we still have a bug with sequence wrap in rtp_queue(). Packet 
> with RTPSeq=0 gets inserted before packet with RTPSeq=65535 (if it's 
> still in queue) which results in:
> 
> rtp demux debug: ignoring late packet (sequence: 65535)


The problem is in incorrect type for delta_sequence, this patch fixes it:

diff --git a/modules/access/rtp/session.c b/modules/access/rtp/session.c
index f3f228b..d7d8cb7 100644
--- a/modules/access/rtp/session.c
+++ b/modules/access/rtp/session.c
@@ -348,8 +348,8 @@ rtp_queue (demux_t *demux, rtp_session_t *session, block_t *
     block_t **pp = &src->blocks;
     for (block_t *prev = *pp; prev != NULL; prev = *pp)
     {
-        int delta_seq = seq - rtp_seq (prev);
-        if (delta_seq < 0)
+        uint16_t delta_seq = seq - rtp_seq (prev);
+        if (delta_seq & 0x8000)
             break;
         pp = &prev->p_next;
     }


With kind regards,

       M.