[vlc-devel] commit: Remove unused alloca.h, add an assertion ( Rafaël Carré )
fenrir at via.ecp.fr
Thu Sep 3 21:27:06 CEST 2009
On Thu, Sep 03, 2009, Rafaël Carré wrote:
> On Thu, 3 Sep 2009 17:19:26 +0200
> Laurent Aimar <fenrir at via.ecp.fr> wrote:
> > On Thu, Sep 03, 2009, Rafaël Carré wrote:
> > > On Thu, 3 Sep 2009 16:37:16 +0200
> > > Laurent Aimar <fenrir at via.ecp.fr> wrote:
> > > > > + assert( p_aout->p_mixer );
> > > > I don't think this one is valid.
> > > > > aout_FifoInit( p_aout, &p_input->mixer.fifo,
> > > > > p_aout->p_mixer->fmt.i_rate ); p_input->mixer.begin = NULL;
> > >
> > > It is dereferenced
> > > here ^^
> > I will check, but it is probably an error, and p_aout->mixer_format
> > should be used instead (in the whole function).
> I triggered this by playing a52 after removing spdif mixer module
Correct check in ac5d4e03b984753d8a350efa8f8399867fa20266.
Could you confirm that there is no segfault now ?
More information about the vlc-devel