[vlc-devel] commit: Remove unused alloca.h, add an assertion ( Rafaël Carré )

[Rafaël Carré]

On Thu, 3 Sep 2009 21:27:06 +0200
Laurent Aimar <fenrir at via.ecp.fr> wrote:

> Hi,
> 
> On Thu, Sep 03, 2009, Rafaël Carré wrote:
> > On Thu, 3 Sep 2009 17:19:26 +0200
> > Laurent Aimar <fenrir at via.ecp.fr> wrote:
> > > On Thu, Sep 03, 2009, Rafaël Carré wrote:
> > > > On Thu, 3 Sep 2009 16:37:16 +0200
> > > > Laurent Aimar <fenrir at via.ecp.fr> wrote:
> > > > > > +    assert( p_aout->p_mixer );
> > > > >  I don't think this one is valid.
> > > > > >      aout_FifoInit( p_aout, &p_input->mixer.fifo,
> > > > > > p_aout->p_mixer->fmt.i_rate ); p_input->mixer.begin = NULL;
> > > > 
> > > > It is dereferenced
> > > > here                                              ^^
> > > I will check, but it is probably an error, and
> > > p_aout->mixer_format should be used instead (in the whole
> > > function).
> > 
> > I triggered this by playing a52 after removing spdif mixer module
>  Correct check in ac5d4e03b984753d8a350efa8f8399867fa20266.
> Could you confirm that there is no segfault now ?

It is fixed, thanks

The sample segfaults somewhere else though:

...
[0x1aff5f0] main audio output error: no suitable audio mixer
[0x1aff5f0] main audio output debug: input 'a52 ' 48000 Hz Stereo
frame=1536 samples/1536 bytes
[0x7f77bc003e80] main decoder debug: End of audio preroll
zsh: segmentation fault (core dumped)  vlc --no-media-library -I rc -vv
--no-video -A dummy newmobcal1280_12mbps.ts

Core was generated by `vlc --no-media-library -I rc -vv --no-video -A
dummy newmobcal1280_12mbps.ts'. Program terminated with signal 11,
Segmentation fault. #0  0x0000000001b1cf04 in ?? ()
(gdb) bt
#0  0x0000000001b1cf04 in ?? ()
#1  0x00007f77aef2bb9c in block_Release (p_demux=0x1ae7fb0,
pid=0x7f77c0004c80) at ../../../vlc/include/vlc_block.h:157
#2  block_ChainRelease (p_demux=0x1ae7fb0, pid=0x7f77c0004c80)
    at ../../../vlc/include/vlc_block.h:212
#3  block_ChainGather (p_demux=0x1ae7fb0, pid=0x7f77c0004c80)
    at ../../../vlc/include/vlc_block.h:278
#4  ParsePES (p_demux=0x1ae7fb0, pid=0x7f77c0004c80)
    at ../../../vlc/modules/demux/ts.c:1803
#5  0x00007f77aef2c859 in GatherPES (p_demux=0x1ae7fb0)
    at ../../../vlc/modules/demux/ts.c:1995
#6  Demux (p_demux=0x1ae7fb0) at ../../../vlc/modules/demux/ts.c:1098
#7  0x00007f77c42eb4ae in demux_Demux (p_input=0x7f77bc000e80)
    at ../../vlc/src/input/demux.h:48
#8  MainLoopDemux (p_input=0x7f77bc000e80)
at ../../vlc/src/input/input.c:606 #9  MainLoop
(p_input=0x7f77bc000e80) at ../../vlc/src/input/input.c:778 #10
0x00007f77c42ebba0 in Run (p_this=<value optimized out>)
at ../../vlc/src/input/input.c:543 #11 0x00007f77c4324474 in
thread_entry (data=<value optimized out>)
at ../../vlc/src/misc/threads.c:57 #12 0x00007f77c4587a04 in
start_thread () from /lib/libpthread.so.0 #13 0x00007f77c487c64d in
clone () from /lib/libc.so.6 #14 0x0000000000000000 in ?? ()
(gdb) frame 1
#1  0x00007f77aef2bb9c in block_Release (p_demux=0x1ae7fb0,
pid=0x7f77c0004c80) at ../../../vlc/include/vlc_block.h:157
157	    p_block->pf_release( p_block );
(gdb) print p_block
$1 = <value optimized out>


-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090903/cb626b77/attachment.sig>