[vlc-devel] commit: Added picture_pool_NewExtended. (Laurent Aimar )

[Laurent Aimar]

On Tue, Sep 08, 2009, Rémi Denis-Courmont wrote:
> 
> 
> 
> On Tue, 8 Sep 2009 02:26:04 +0200, Pierre d'Herbemont
> <pdherbemont at gmail.com> wrote:
> > 
> > 
> > On Sep 7, 2009, at 11:05 PM, "Rémi Denis-Courmont" <remi at remlab.net>  
> > wrote:
> > 
> >> Le lundi 7 septembre 2009 23:57:52 Pierre d'Herbemont, vous avez écr 
> >> it :
> >>> In this case NewWithConfiguration seems more appropriate. And
> >>> "configuration" should  probably be "callback".
> >>
> >> Do you really need to invent the longest possible names all the time?
> > 
> > You are just saying, that short is good. And I do agree.
> > 
> > However someone new to the code will appreciate meaningful and clear  
> > name.   I am always open to better suggestion.
> 
> WithConfiguration reads just as stupid as Extended. In either case, it
> won't scale to further adding parameters.
> 
> > Also, if you want to put it that way, Extended is a waste of 8 chars.
> 
> Yes. We might as well have a single function and give a NULL parameter to
> get the non-extended behavior.
 I really dislike that, you will end up using NULL everywhere except for a
few cases (currently, only vmem and msw modules seems to need it). So I prefer
to use 2 functions.

-- 
fenrir