[vlc-devel] [PATCH] - Updated the browser plugins to use the Media List Player for playlist traversal

jpd at videolan.org jpd at videolan.org
Mon Sep 14 19:11:39 CEST 2009


On Mon, Sep 14, 2009 at 06:13:36PM +0300, R?mi Denis-Courmont wrote:
> But anyway, git refuses to merge your patches (I tried both master and
> 1.0 trees).

Which is good because at least one of the patches won't compile; there's
a stray z on a line somewhere.

Apart from outlining and other cosmetics, I'd like to see unnecessairy
static_cast<bool> removed and replace condition0 ? condition1 : false;
with condition0 && condition1; including in return statements.

As to introducing a media_list, I don't really know the benefits of that
over the existing one, so I won't comment.




More information about the vlc-devel mailing list