[vlc-devel] [PATCH] - Updated the browser plugins to use the Media List Player for playlist traversal

[Jean-Paul Saman]

On Fri, Sep 4, 2009 at 10:49 PM, Niles Bindel <zaggal69 at gmail.com> wrote:

> I've separated the patch into two stages...the first being the conversion
> to Media List Player and the second a cosmetic patch to be applied after the
> first patch.  I also found that my first patch was missing the Mozilla
> plugin changes I made so I've added those changes to these patches as well.
>
> In the first patch there is a change in method onActivateInPlace() which is
not related to the modifications as outlined in the commitlog. Could you
please explain why you took that out of the if( _b_usermode ) branch? (And
preferably separate into another patch.)

@@ -717,17 +770,18 @@ HRESULT VLCPlugin::onActivateInPlace(LPMSG lpMesg,
HWND hwndParent, LPCRECT lprc
     HRGN clipRgn = CreateRectRgnIndirect(&clipRect);
     SetWindowRgn(_inplacewnd, clipRgn, TRUE);

+    /* will run vlc if not done already */
+    libvlc_instance_t* p_libvlc;
+    HRESULT result = getVLC(&p_libvlc);
+    if( FAILED(result) )
+        return result;
+
+    set_player_window(NULL);
+
     if( _b_usermode )
     {
-        /* will run vlc if not done already */
-        libvlc_instance_t* p_libvlc;
-        HRESULT result = getVLC(&p_libvlc);
-        if( FAILED(result) )
-            return result;
-
-        if( _b_autoplay && playlist_select(0,NULL) )
+        if( _b_autoplay && playlist_play_item(0, NULL) )
         {
-            libvlc_media_player_play(_p_mplayer,NULL);
             fireOnPlayEvent();
         }
     }

Gtz
Jean-Paul Saman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090915/14b35768/attachment.html>