[vlc-devel] commit: Removed useless fb-chroma option. (Laurent Aimar )

[Laurent Aimar]

Hi,

On Mon, Sep 28, 2009, Rafaël Carré wrote:
> On Mon, 31 Aug 2009 00:37:30 +0200 (CEST)
> git at videolan.org (git version control) wrote:
> 
> > vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Sun Aug
> > 30 22:09:47 2009 +0200| [14c1f6dead1d7288188244bb396f36216e26536c] |
> > committer: Laurent Aimar 
> > 
> > Removed useless fb-chroma option.
> > 
> > It could not work.
> 
> Why couldn't it work ?
> 
> It's useful on TI Davinci dm6446 device which has 4 different
> framebuffers with different image formats (2 * UYVY, 1 * RV16, 1 custom)
 Ok, I didn't know that.

> There's no way to know the image format from the linux fb API, so you
> have to specify it (with --fb-chroma)
 From what I saw, the chroma was autodetected by looking at
var_info.bits_per_pixel (and assuming RGB). In such cases, overriding
the chroma was wrong and cannot work. Now, if fb can also provide
YUV without any means of detection, I can understand the use of fb-chroma.
If re-added, it would be great to have a better description of fb-chroma.

Regards,

-- 
fenrir