[vlc-devel] [PATCH] Add support for mpg123 decoder

William Hahne will07c5 at gmail.com
Thu Apr 1 22:59:00 CEST 2010

Since mpgatofixed32 needs the extra 8 bytes, it is easier to remove
the bytes than store the frame and wait until the next one before
sending them to mad. I just made mpgatofixed32_mpg123 remove the last
8 bytes. I can do it the other way but it will have to wait until next
week since I really need to spend time writing my proposal and dealing
with all the homework I have to do.


William Hahne (IRC: Will07c5)

On Thu, Apr 1, 2010 at 2:23 PM, Laurent Aimar <fenrir at babylon.via.ecp.fr> wrote:
> Hi,
>  The extra data appended by mpeg_audio.c for mad decoder is really a hack that
> should be moved to mpgatofixed32.c.
>  This would be cleaner and will avoid all those checks on
>  module_exists( "mpgatofixed32_mpg123" )
> (which are not really ok, even if "mpgatofixed32_mpg123" exists, it doesn't
> means it will always be used).
> Regards,
> --
> fenrir
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123.patch
Type: application/octet-stream
Size: 11338 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100401/e8a7daf7/attachment.obj>

More information about the vlc-devel mailing list