[vlc-devel] [PATCH] Add support for mpg123 decoder

Jean-Baptiste Kempf jb at videolan.org
Tue Apr 13 13:10:30 CEST 2010

On Thu, Apr 01, 2010 at 02:59:00PM -0600, William Hahne wrote :
> Since mpgatofixed32 needs the extra 8 bytes, it is easier to remove
> the bytes than store the frame and wait until the next one before
> sending them to mad. I just made mpgatofixed32_mpg123 remove the last
> 8 bytes. I can do it the other way but it will have to wait until next
> week since I really need to spend time writing my proposal and dealing
> with all the homework I have to do.

 - Copyright and dates are wrong and AUTHORS too.
 - Configure.ac should use PKG_CONFIG instead of this complex detection
 - I believe filter_sys_t should be reordered (or maybe off_t isn't a long )
 - I believe you should return VLC_SUCCESS and not 0 in OpenFilter
 - I believe you are leaking p_sys when VLC_EGENERIC is throws in OpenFilter

And that's all from me ;)

Jean-Baptiste Kempf

More information about the vlc-devel mailing list