[vlc-devel] [vlc-commits] commit: qt4: Don't create QMenu without parents (Erwan Tulou )

[Jakob Leben]

On Wed, Apr 7, 2010 at 10:07 AM, brezhoneg1 <brezhoneg1 at yahoo.fr> wrote:

>
> hi,
>
>    I fear things are a lot more complicated
>
>     -  There is not one popmenu menu but four independent popmenus
> (PopMenu, VideoPopupMenu, AudioPopupMenu, MiscPopupMenu)
>     (see dialogs_provider.cpp around line 162)
>

I think other ones besides PopupMenu are not used anywhere.



>
>     - today's implementation processes PopMenu in a certain way (with
> p_intf->p_sys->p_popup_menu ) and the three others in another way.
>

The three others are just plain leaks and wrong, so if they are ever going
to be used, they should do the same as PopupMenu does.


>
>  To sum it up
>
>     - there is much work to do for menus
>

Yes, I agree, I guess everyting could be more elegant, without even needing
MenuItemData.



>     - Since it's feature freeze, my patch is still the shortest way to work
> out
>        the problem, yet not redesign the whole menu thing
>     - This patch is necessary because we cannot afford to leave vlc objects
> unreleased


Please try my attached patch (locally revert your commit [8d8bd80666aff]
before, or my patch won't apply).
How short can it be? :)

Best regards,
Jakob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100407/6e2eaf57/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Qt-unify-popup-menu-triggering-and-prevent-memory-le.patch
Type: text/x-diff
Size: 3306 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100407/6e2eaf57/attachment.patch>