[vlc-devel] [PATCH] Add support for mpg123 decoder

[William Hahne]

The assert was there for testing since technically the filter should
never receive a buffer less than 8 bytes long, but escaping the
function is probably better than just crashing. Regarding autotools I
really have had very little experience with them, so if I haven't
gotten it right this time I probably need more detail as to what you
want there. I personally think the while loops seem cleaner in this
scenario but if you have a good argument for replacing them with for
loops I will do it.

Will

On Thu, Apr 15, 2010 at 3:33 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> Hello,
>
> Do not excuse yourself, no pb.
>
>
>> I fixed
>> the issues you identified as well as some other minor stuff (missing
>> p_ prefix on a pointer). I noticed that the VLC_SUCCESS was also
>> missing in the original mpgatofixed32.c so I probably will make a
>> patch for that too.
> Ok.
>
> Are we sure we want to assert, on the buffer - 8 part? Escaping the
> function might be better? (No idea, here)
>
> Else, no need for Authors, this file is a mess.
> About configure.ac, you should be able to use PKG_ENABLE_MODULES_VLC
> You know VLC is C99 ? You can declare loop counters inside the for(
>
> Anyway, I believe we need Laurent's review here.
>
> Best Regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123_3.patch
Type: application/octet-stream
Size: 10099 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100415/d6beb7d8/attachment.obj>