[vlc-devel] [PATCH] Add support for mpg123 decoder

Jean-Baptiste Kempf jb at videolan.org
Thu Apr 15 10:33:26 CEST 2010


On Wed, Apr 14, 2010 at 08:52:29PM -0500, William Hahne wrote :
> Sorry for the delay, I've been very busy with school lately.
Do not excuse yourself, no pb.

> I fixed
> the issues you identified as well as some other minor stuff (missing
> p_ prefix on a pointer). I noticed that the VLC_SUCCESS was also
> missing in the original mpgatofixed32.c so I probably will make a
> patch for that too.

Are we sure we want to assert, on the buffer - 8 part? Escaping the
function might be better? (No idea, here)

Else, no need for Authors, this file is a mess.
About configure.ac, you should be able to use PKG_ENABLE_MODULES_VLC
You know VLC is C99 ? You can declare loop counters inside the for(

Anyway, I believe we need Laurent's review here.

Best Regards,

Jean-Baptiste Kempf

More information about the vlc-devel mailing list