[vlc-devel] [PATCH] Remove .txt subtitle loading

[Kaarlo Räihä]

2010/8/1 Jean-Baptiste Kempf <jb at videolan.org>

> On Sat, Jul 31, 2010 at 09:17:31PM +0300, Kaarlo Räihä wrote :
> > Some people have complained in forums that VLC tries to autoload .txt
> files
> > as subtitles since they have same kind of name as input file (
> > http://forum.videolan.org/viewtopic.php?f=14&t=55979#p244039 ). But
> because
> > those .txt files aren't subtitles, VLC will complain with dialog that
> says
> > 'format of 'something.txt' cannot be detected. Have a look at the log for
> > details'. So I made patch that removes .txt from supported subtitle file
> > extension list and users will avoid the dialogs.
> >
> > I haven't heard that anyone uses .txt extension for subtitle file (at
> least
> > subbers avoid it) and thus this shouldn't cause issues for regular users
> > (QT4 subtitle loading dialog doesn't even offer .txt extension at all).
> > Problem is that same check function (subtitles_Filter) is used in
> control.c
> > (line 367) and with removal of .txt those subtitles cannot be loaded
> > anymore. There are better ways to solve the problem (like customizable
> > subtitle autoload extension list for users) but I would guess this easy
> > solution is good enough.
>
> No, I don't think this is a good idea.
> Why not make the errors when loading of a subtitle silent when it is
> auto-detected?
>

Because the dialog is created by InputSourceInit function in
src/input/input.c which AFAIK has no information if the subtitle is
autoloaded or not. And storing (+using) information like that for single
error dialog in case like this is IMHO pointless and we would have to add
subtitle specific code InputSourceInit which would make it look ugly.


>
> Best Regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100802/f241461f/attachment.html>