[vlc-devel] [PATCH] Remove .txt subtitle loading

Rémi Denis-Courmont remi at remlab.net
Thu Aug 5 18:38:27 CEST 2010


Le lundi 2 août 2010 12:23:39 Kaarlo Räihä, vous avez écrit :
> > No, I don't think this is a good idea.
> > Why not make the errors when loading of a subtitle silent when it is
> > auto-detected?
> 
> Because the dialog is created by InputSourceInit function in
> src/input/input.c which AFAIK has no information if the subtitle is
> autoloaded or not. And storing (+using) information like that for single
> error dialog in case like this is IMHO pointless and we would have to add
> subtitle specific code InputSourceInit which would make it look ugly.

We could add an input item option to inhibit error dialogs. We would need to 
move --qt-error-dialogs to the dialog core. I am not sure this is a good idea 
though.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list